deep dive country maps #118
Merged
+261
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #116 |
|
Somethin is wrong with the morocco subregions. They cover only a small section of the country, and names and shapes are not assigned correctly (eg Casablanca should be on the west coast)
|
|
Can we adjust the xy range for the south africa map to only include the mainland? It is zoomed out very far because of two small islands far to the south
|
|
the south africa map also seems to have some subregions missing: country map: subregions map: |
markushal
reviewed
Nov 17, 2023
labels from natural earth dataset do not correspond with iso3166-2 from wikipedia
they belong to Western Cape but we don't need them on the map.
|
Hi @markushal, thanks for checking and catching errors. I addressed your points, should work as expected now. |
markushal
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Markus,
I changed the plot function for costs on a map and added maps for the deep dive countries, please have a look.
I also added the changed colorbar height and figure size from #117